1
0
Fork 0
Commit graph

1858 commits

Author SHA1 Message Date
Luiz Capitulino
793e6c8319 profiles: Improve 'isolated_cores=' help text
Just explain what isolated_cores= is for and recommend to only have one
isolated_cores= line to avoid wrong system configuration.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
2023-11-28 11:15:47 +01:00
Jaroslav Škarvada
2652d7c29d
Merge pull request #572 from zacikpa/amd-pstate
Be explicit about amd-pstate support
2023-11-23 00:52:54 +01:00
Pavol Žáčik
f03e1d0d24
Be explicit about amd-pstate support
Resolves: RHEL-16469

Since intel_pstate and amd-pstate use the same per-CPU interface
for setting EPP hints, the current cpu plugin supports amd-pstate
out of the box.

This commit modifies current P-state related logs and variable
names to be explicit about the support for amd-pstate.

Note that while intel_pstate supports global attributes such as
`max_perf_pct`, amd-pstate does not.
2023-11-21 08:36:01 +01:00
Jaroslav Škarvada
1460175f08
Merge pull request #570 from yarda/re-fix-escape
Fixed REs escape sequences not to trigger SyntaxWarning
2023-11-15 20:55:12 +01:00
Jaroslav Škarvada
5d3b469a9d
Merge pull request #569 from zacikpa/get-instances
Add API functions to retrieve active instances and their devices
2023-11-14 16:37:03 +01:00
Jaroslav Škarvada
e3ee28297a
Fixed REs escape sequences not to trigger SyntaxWarning
Python 3.12 is more strict about correct escaping and
outputs SyntaxWarning for invalid escape sequences that
were previously silently corrected.

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-11-14 16:32:03 +01:00
Pavol Žáčik
db6b880bb6
Add API functions to retrieve active instances and their devices
Resolves: RHEL-15137

Appropriate commands are added to tuned-adm as well.

`get_instances`: Retrieves a list of active instances of a given
plugin or all active instances.

`instance_get_devices`: Retrieves a list of devices assigned
to a given instance.
2023-11-14 15:36:12 +01:00
Jaroslav Škarvada
101cbf03bb
Merge pull request #566 from zacikpa/tuned-adm-acquire-devices
Add a tuned-adm command for moving devices between plugin instances
2023-11-09 23:08:22 +01:00
Pavol Žáčik
f58c25d0bc
Add a tuned-adm command for moving devices between plugin instances
Resolves: RHEL-15141

Until now, this was only possible by manually sending a message to
TuneD via the DBus API.
2023-11-09 19:58:34 +01:00
Jaroslav Škarvada
96819b967c
Merge pull request #555 from MarSik/fix-sysctl-path
RHEL-3707: Add support for sysctl names with slash
2023-11-08 20:58:11 +01:00
Martin Sivak
6ca3f5a93c
Add support for sysctl names with slash
Resolves: RHEL-3707

The logic for converting sysctl names to paths did not work for
sysctls like "net.ipv4.conf.bond0/355.forwarding" because it
contains a slash. According to the sysctl.d manpage, the dots
and slashed must be interchanged if the first separator is a
dot, which we assume.
2023-11-08 11:16:52 +01:00
Pavol Žáčik
114daf0397
Make all functions in plugin_sysctl.py methods of SysctlPlugin
This is necessary for the functions to use the _cmd attribute of
the class.
2023-11-08 11:06:21 +01:00
Jaroslav Škarvada
370a80a065
Merge pull request #546 from yarda/spdx
Converted SPEC file license to SPDX
2023-11-06 15:28:59 +01:00
Jaroslav Škarvada
569c6f58e1
Merge pull request #557 from kenneth-dsouza/tuned_fix
RHEL-3689: Print all arguments of failing command in err_msg
2023-10-24 09:01:36 +02:00
Kenneth D'souza
f7f9c0dedb RHEL-3689: Print all arguments of failing command in err_msg
Improve error log by printing all arguments passed to command.
This helps in troubleshooting issues where just knowing the command is
not enough, we need more details on which settings, devices and options
has caused this error.

Signed-off-by: Kenneth D'souza <kennethdsouza94@gmail.com>
2023-10-24 09:45:04 +05:30
Jaroslav Škarvada
5224682d25
Merge pull request #558 from adriaan42/style/whitespace-in-plugin_cpu
style: fix inconsistent whitespace in plugin_cpu.py
2023-10-12 14:14:06 +02:00
Jaroslav Škarvada
e6914b50a4
Merge pull request #553 from liuzhilin12/master
fix error
2023-10-12 14:03:36 +02:00
Jaroslav Škarvada
9a27fc6879
Merge pull request #556 from jmencak/ksm-return-0
Return 0 when ksm services do not exist
2023-10-12 14:02:45 +02:00
Adriaan Schmidt
c9d50ecf34 style: fix inconsistent whitespace in plugin_cpu.py
Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
2023-09-28 12:26:48 +02:00
Jiri Mencak
158a3e83c9 Return 0 when ksm services do not exist
When ksm or ksmtuned services do not exist, return 0 so that we do not
generate ERRORs in TuneD logs.

Resolves: OCPBUGS-19656

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>
2023-09-24 20:54:34 +02:00
Jaroslav Škarvada
670541d273
new release (2.21.0)
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-08-29 13:54:01 +02:00
liuzhilin
81fdebd313 fix error 2023-08-28 10:23:04 +08:00
Jaroslav Škarvada
1e33d23f16
Merge pull request #552 from yarda/api-stop-method-fix
api: fixed stop method not to require any parameter
2023-08-22 22:39:47 +02:00
Jaroslav Škarvada
c7a3544fa9
api: fixed stop method not to require any parameter
Fixes #551

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-08-22 17:08:22 +02:00
Jaroslav Škarvada
e01ff5db2a
new release (2.21.0-rc.1)
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-08-20 23:27:36 +02:00
Jaroslav Škarvada
9a38e1bf2c
Merge pull request #549 from yarda/tuned-gui-fixes
gui: multiple fixes and warnings removal
2023-08-18 01:07:20 +02:00
Jaroslav Škarvada
b448eb6fd4 gui: multiple fixes and warnings removal
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-08-18 00:43:10 +02:00
Jaroslav Škarvada
3d4a5cd20e
Merge pull request #548 from yarda/tuned-gui
gui: fixed inconsistent tabs and spaces, introduced by #516
2023-08-17 23:55:28 +02:00
Jaroslav Škarvada
6a67b3273e
Merge pull request #547 from yarda/sighup-serialize
Serialize SIGHUP processing
2023-08-17 23:48:27 +02:00
Jaroslav Škarvada
e047f7ad5e
gui: fixed inconsistent tabs and spaces, introduced by #516
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-08-17 15:17:15 +02:00
Jaroslav Škarvada
60d54c3698
Serialize SIGHUP processing
Resolves: rhbz#2215298

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-08-17 14:55:50 +02:00
Jaroslav Škarvada
03375968cd
Merge pull request #542 from jmencak/rhbz2217015-no-errors-on-offline-cpus
No errors when physical_package_id file does not exist
2023-08-16 23:02:01 +02:00
Jiri Mencak
a0902c27b3 No errors when physical_package_id file does not exist
Show no errors when the physical_package_id file does not exist -- the
CPUs may be offline.

Resolves: rhbz#2217015

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>
2023-08-16 22:40:03 +02:00
Jaroslav Škarvada
2bf04151d9
Merge pull request #516 from uniontech-lilinjie/add-dialog
add error dialog when no active profile set
2023-08-16 20:42:28 +02:00
Jaroslav Škarvada
aa0f6c25a9
Merge pull request #526 from bhllamoreaux/plugin-net-expand
plugin_net: expand variables properly
2023-08-16 20:29:44 +02:00
Jaroslav Škarvada
fdb40fb290
Merge pull request #538 from jmencak/rollback-rename
Rename rollback-related constants and variables
2023-08-16 20:27:31 +02:00
Jaroslav Škarvada
e2087f57d4
Converted SPEC file license to SPDX
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
2023-08-09 16:10:02 +02:00
Jaroslav Škarvada
f4c976f2f5
Merge pull request #421 from RHEmployee/ratelimit
Update tests: disable systemd rate limiting.
2023-08-03 18:48:17 +02:00
Robin Hack
178bc00dc8 Update tests: disable systemd rate limiting. 2023-07-27 08:03:42 -04:00
Jaroslav Škarvada
54151a7fcc
Merge pull request #539 from matosatti/realtime-cleanups
Realtime cleanups
2023-06-20 23:49:52 +02:00
Marcelo Tosatti
cbcd1df901 network-latency: enable rcu_normal_after_boot=1 kernel parameter
The rcu_normal_after_boot=1 kernel parameter (which is enabled by
default on CONFIG_PREEMPT_RT kernels) avoids the use of IPIs
to expedite the runtime of synchronize_rcu_expedited() callers.

Enable this in tuned to avoid such IPIs on !CONFIG_PREEMPT_RT kernels
as well.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
2023-06-20 14:15:42 -03:00
Marcelo Tosatti
925898b522 remove ktimer_lockless_check sysfs setting from realtime-virtual profiles
The ktimer_lockless_check interface was removed from Red Hat kernels.
Drop the tuned configuration as well.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
2023-06-20 14:15:42 -03:00
Marcelo Tosatti
3747701d1c move rtentsk to network-latency profile
The interruptions avoided by the rtentsk logic:

"Add plugin to open a socket with SOF_TIMESTAMPING_OPT_TX_SWHW.

This is for avoiding interruptions due to static key IPIs due
to opening socket with timestamping enabled (by opening a
socket ourselves the static key is kept enabled)."

Are also desired on systems that use cpu-partitioning.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
2023-06-20 14:15:42 -03:00
Marcelo Tosatti
c9c81093be move "tsc=reliable" setting from realtime to network-latency tuned configuration
Commit 49cc817871
("realtime: Set tsc as 'reliable'") reads:

"We already disable the clocksource watchdog, it's there to double-check
whether clock results are coherent between reads. But a new reliability
test was introduced in recent kernels[1], tracking tsc drift between
CPUs[2]. It works by programming timers on all CPUs, including isolated
ones, and checks whether the tsc was adjusted in between runs. This
introduces unwarranted latency on real time systems. So let's promote
tsc to 'reliable', which disables both checks."

The timer is also undesired interruption to systems that use cpu-partitioning.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
2023-06-20 14:15:42 -03:00
Marcelo Tosatti
4a622d2b5f unify common sysctl settings between realtime and cpu-partitioning profiles
The following sysctl settings are the same between cpu-partitioning and
realtime profiles:

kernel.hung_task_timeout_secs = 600
kernel.nmi_watchdog = 0
vm.stat_interval = 10
kernel.timer_migration = 0

Unify them in the network-latency profile, parent of both profiles.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
2023-06-20 14:15:42 -03:00
Jiri Mencak
a26f426430 Rename rollback-related constants and variables
This is a follow-up cleanup PR as agreed in #533.

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>
2023-06-16 10:02:57 +02:00
Jaroslav Škarvada
850368d2f8
Merge pull request #533 from jmencak/rollbacks
Add rollback_on_exit option
2023-06-14 23:40:32 +02:00
Jiri Mencak
7f3a79bbd6 Add rollback option to tuned-main.conf
Add rollback option to tuned-main.conf file.  The option specifies how
TuneD should perform rollbacks.  By default, the old behaviour is
preserved (rollback=auto) and settings are rolled back on TuneD daemon
exit and profile switches.  Using rollback=not_on_exit will result in
TuneD not performing any rollbacks on the daemon exit, however, on
profile switches, settings rollbacks will still be performed.

Resolves: rhbz#2203142

Signed-off-by: Jiri Mencak <jmencak@users.noreply.github.com>
2023-06-14 14:09:30 +02:00
Jaroslav Škarvada
f65b43d1dd
Merge pull request #529 from newkit/master
Added sap-hana-kvm-guest profile
2023-06-14 10:51:06 +02:00
Jaroslav Škarvada
47e6640b9a
Merge pull request #530 from newkit/feature/fixdocu
fixed sap-hana docu regarding processor power settings
2023-06-14 10:46:48 +02:00