This makes the function output shorter which is desirable
with many CPUs when the function is used, e.g., to compute
the content of the isolcpus kernel argument.
Resolves: RHEL-75751
Same for dirty_background_ratio and dirty_background_bytes.
Using both the ratio and the bytes is not compatible with
the current profile inheritance implementation, because it
is not possible for dirty_bytes in a child profile to override
dirty_ratio in its parent profile.
Resolves: RHEL-101578
The inodes backing the kernfs virtual files for the attributes we watch
may be dropped by the kernel due to memory exhaustion or explicit user
action (sysctl vm.drop_caches). This causes inotify events to not be
delivered as kernfs_notify() simply drops the event if the inode cannot
be found in the kernel caches.
Fix this by explicitly pinning the attributes virtual files in memory to
ensure we receive inotify events.
If TuneD-appended kargs are present and do not match
the kargs to be appended, we should remove them. This
can happen if there was no profile rollback, e.g.,
when using the no-daemon mode.
Resolves: RHEL-86814
The bootloader plugin claims that it does not mess
with existing kernel parameters; make sure we adhere
to that also for rpm-ostree systems:
1. Only append a new karg if the same key=value pair
does not already appear in kernel parameters. If we would
duplicate it, it would not be possible to determine which
one to delete when unapplying the profile.
2. Do not delete existing key=value pairs when the profile
adds a karg with another value for the key. A single key can
appear multiple times in the kernel parameter list with different
values.
Also make sure new kargs are added exactly in the order in which
they appear in the profile. This is especially important for kargs
related to hugepages.
Resolves: RHEL-45836
It now uses TuneD udev events buffer size which is by default 1 MB
instead of the 8 kB default udev buffer size. The buffer size is
configurable in the tuned-main.conf. This should prevent filling
of the buffer even in case of a storm of udev events. It also
contains workaround for the pyudev bug:
https://github.com/pyudev/pyudev/issues/194
Even if the buffer is filled now, the udev queue is no more stuck
and error is logged.
Resolves: RHEL-92637
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
Add support for MMC (MultiMediaCard) devices in tuned's
disk plugin.
fixes: #776
Signed-off-by: Brian King <1854985+inflatador@users.noreply.github.com>
Timeout in seconds to maximally wait until udev settles. If set to value
bigger than 0, it will either wait until udev settles or the timeout
occurs. Disable with 0.
Resolves: RHEL-88238
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
This way, the exception gets caught in tuned.py,
which prints an error message and exits with
non-zero error code, providing feedback to
tuned-adm. Previously, tuned-adm would have no
way of knowing that TuneD failed.
Resolves: RHEL-71304
Tuning ALPM for external SATA ports is incompatible
with reliable detection of hot plug removals (see
SATA AHCI 1.3.1, section 7.3.1). This commit skips
the ALPM setting for such ports, i.e., for all ports
that have either the ESP bit (External SATA Port)
or the HPCP bit (Hot Plug Capable Port) set to 1
in the PxCMD register (exposed in `ahci_port_cmd`).
Resolves: RHEL-79913
During profile loading if the device is assigned to the instance but it
isn't processed yet by the main thread and the remove event fires, TuneD
may try to remove the device from the free list, because it wrongly assumes
that the device is unassigned. With this workaround it shouldn't traceback
in such cases, but there may be still some errors when it tries to tune the
removed device in the main thread. We currently cannot do much about it.
The add/rename udev events should be mostly safe, because there are two
threads - the main thread and the udev callback thread. The udev
callback thread is processing udev events sequentially one by one and it
shouldn't break the main thread data when processing the add/rename
events. It would be better to have one worker thread for it, but it
would require quite a big redesign.
Also the cleanup phase was improved, because now it firstly unsubscribes
the udev events and then it continues with the cleanup which should
minimise problems of udev events firing during the profile unload.
Resolves: RHEL-83827
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
Now the irqbalance plugin will work even if perf is unavailable. Also
improved perf detection in the scheduler plugin. If the perf.cpu_map()
fails for some reason, perf is disabled and the perf library will not
segfault.
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
This enables child profiles to use new variables in the definitions
of variables that they overwrite in parent profiles.
Also allow multiple instances of variable units, with the same
rules as plugins have.
Resolves#751.
If the platform profile is changed outside of tuned then the update
does not get reflected in tuned-adm and gnome-settings.
This is particularly noticeable on Thinkpads where the F8 Mode key
changes the profile but the change is not reflected. It can also be
demonstrated by changing the profile from the command line.
Enable the feature by default. It works well and is useful.
Tested on multiple Thinkpads, but I expect it to be useful to other
vendor platforms too.
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Instead of hardcoding a path, use
`tuned.consts.USER_PROFILES_DIR` as the location
where we should expect to find profile directories
that we've been asked to delete.
Without the redirect to /dev/null, an error message would
be reported in TuneD logs on aarch64 machines, which do not
have the kernel module.
Resolves: RHEL-79943
The thinkpad_function_keys feature really doesn't have anything to
do with Thinkpad function keys. It is just monitoring for sysfs events
from firmware/acpi/platform_profile
Rename the feature to be more accurate. It is useful to other platforms
than Thinkpads :)
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
