nikon/docsearch
1
0
Fork 0
Code Activity Actions

feat(v3): require appId (#1299)

Browse source 
BREAKING CHANGE
This commit is contained in:
Clément Vannicatte 2022-02-21 13:59:53 +01:00 committed by GitHub
parent b91983dc56
commit 80630cb36d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/docsearch-react/src/DocSearch.tsx
View file

@ -24,7 +24,7 @@ export type DocSearchTranslations = Partial<{
}>;
export interface DocSearchProps {
appId?: string;
appId: string;
apiKey: string;
indexName: string;
placeholder?: string;

2
packages/docsearch-react/src/DocSearchModal.tsx
View file

@ -35,7 +35,7 @@ export type DocSearchModalProps = DocSearchProps & {
};
export function DocSearchModal({
appId = 'BH4D9OD16A',
appId,
apiKey,
indexName,
placeholder = 'Search docs',

4
packages/docsearch-react/src/__tests__/api.test.tsx
View file

@ -13,7 +13,9 @@ import { DocSearch as DocSearchComponent } from '../DocSearch';
import type { DocSearchProps } from '../DocSearch';
function DocSearch(props: Partial<DocSearchProps>) {
return <DocSearchComponent apiKey="foo" indexName="bar" {...props} />;
return (
<DocSearchComponent appId="woo" apiKey="foo" indexName="bar" {...props} />
);
}
// mock empty response