From 80630cb36dcfe486eff4f7b859deef5431775045 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Vannicatte?= <20689156+shortcuts@users.noreply.github.com> Date: Mon, 21 Feb 2022 13:59:53 +0100 Subject: [PATCH] feat(v3): require appId (#1299) BREAKING CHANGE --- packages/docsearch-react/src/DocSearch.tsx | 2 +- packages/docsearch-react/src/DocSearchModal.tsx | 2 +- packages/docsearch-react/src/__tests__/api.test.tsx | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/docsearch-react/src/DocSearch.tsx b/packages/docsearch-react/src/DocSearch.tsx index 26cded14..83da36ad 100644 --- a/packages/docsearch-react/src/DocSearch.tsx +++ b/packages/docsearch-react/src/DocSearch.tsx @@ -24,7 +24,7 @@ export type DocSearchTranslations = Partial<{ }>; export interface DocSearchProps { - appId?: string; + appId: string; apiKey: string; indexName: string; placeholder?: string; diff --git a/packages/docsearch-react/src/DocSearchModal.tsx b/packages/docsearch-react/src/DocSearchModal.tsx index d4cdc421..2d82ab44 100644 --- a/packages/docsearch-react/src/DocSearchModal.tsx +++ b/packages/docsearch-react/src/DocSearchModal.tsx @@ -35,7 +35,7 @@ export type DocSearchModalProps = DocSearchProps & { }; export function DocSearchModal({ - appId = 'BH4D9OD16A', + appId, apiKey, indexName, placeholder = 'Search docs', diff --git a/packages/docsearch-react/src/__tests__/api.test.tsx b/packages/docsearch-react/src/__tests__/api.test.tsx index efd23979..ec5ab335 100644 --- a/packages/docsearch-react/src/__tests__/api.test.tsx +++ b/packages/docsearch-react/src/__tests__/api.test.tsx @@ -13,7 +13,9 @@ import { DocSearch as DocSearchComponent } from '../DocSearch'; import type { DocSearchProps } from '../DocSearch'; function DocSearch(props: Partial) { - return ; + return ( + + ); } // mock empty response