1
0
Fork 0

Skip calling rpm-ostree kargs in no-op case

If delete and append kargs args are the same in the same order
there is no functional differences so we can safely skip
calling rpm-ostree kargs and avoid creating a new rpm-ostree
deployment.

Resolves: RHEL-20767

Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
This commit is contained in:
Etienne Champetier 2024-01-04 22:33:26 +02:00
parent 954bc4624d
commit dd5355804a

View file

@ -304,6 +304,10 @@ class BootloaderPlugin(base.Plugin):
kargs.setdefault(k, []).extend(val)
appended[k] = val
if append_params == delete_params:
log.info("skipping rpm-ostree kargs - append == deleting (%s)" % append_params)
return kargs, appended, deleted
log.info("rpm-ostree kargs - appending: '%s'; deleting: '%s'" % (append_params, delete_params))
(rc, _, err) = self._cmd.execute(['rpm-ostree', 'kargs'] +
['--append=%s' % v for v in append_params] +