From da630790efc2e8effb81fbb65fa0312c518f8bd2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Lyson=C4=9Bk?= Date: Thu, 13 Apr 2017 15:38:44 +0200 Subject: [PATCH] plugin_net: Fix invocation of execute() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix an invocation of execute() after its API changed. Reproducer: Run tuned with the following profile, and you'll see error messages 'tuned.utils.commands: Executing ethtool error: ethtool: bad command line argument(s)' in the log. Replace 'enp0s25' with your ethernet interface: [net] devices=enp0s25 coalesce=rx-usecs 4 Signed-off-by: Ondřej Lysoněk --- tuned/plugins/plugin_net.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tuned/plugins/plugin_net.py b/tuned/plugins/plugin_net.py index cc5bca1..4399fc8 100644 --- a/tuned/plugins/plugin_net.py +++ b/tuned/plugins/plugin_net.py @@ -269,7 +269,7 @@ class NetTuningPlugin(base.Plugin): if not sim: log.debug("setting %s: %s" % ("coalesce" if coalesce else "features", str(d))) # ignore ethtool return code 80, it means parameter is already set - self._cmd.execute(["ethtool", "-C" if coalesce else "-K", device] + self._cmd.dict2list(d), [80]) + self._cmd.execute(["ethtool", "-C" if coalesce else "-K", device] + self._cmd.dict2list(d), no_errors = [80]) return d def _custom_parameters(self, coalesce, start, value, device, verify):