From 10f723780a33a9e10ec2e86171dc7964cb1feffc Mon Sep 17 00:00:00 2001 From: Jan Vcelak Date: Tue, 27 Nov 2012 17:26:01 +0100 Subject: [PATCH] norefs, disk: fix spindown value setting --- tuned/plugins/plugin_disk.py | 5 ++--- tuned/utils/commands.py | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tuned/plugins/plugin_disk.py b/tuned/plugins/plugin_disk.py index ddd63e4..389aa3f 100644 --- a/tuned/plugins/plugin_disk.py +++ b/tuned/plugins/plugin_disk.py @@ -2,7 +2,6 @@ import base from decorators import * import tuned.logs import tuned.utils.commands - import os log = tuned.logs.get() @@ -191,12 +190,12 @@ class DiskPlugin(base.Plugin): @command_set("spindown", per_device=True) def _set_spindown(self, value, device): - pass + tuned.utils.commands.execute(["hdparm", "-S", value, "/dev/" + device]) @command_get("spindown") def _get_spindown(self, device): # TODO: ticket #23, There's no way how to get current/old spindown value. - tuned.utils.commands.execute(["hdparm", "-S", value, "/dev/" + device]) + pass def _readahead_file(self, device): return os.path.join("/sys/block/", device, "queue/read_ahead_kb") diff --git a/tuned/utils/commands.py b/tuned/utils/commands.py index fb1ad5b..e1716c8 100644 --- a/tuned/utils/commands.py +++ b/tuned/utils/commands.py @@ -28,6 +28,7 @@ def read_file(f): def execute(args): + log.debug("Executing %s." % str(args)) out = "" try: proc = Popen(args, stdout=PIPE, stderr=PIPE)