From 1b9952fa9d7a85506e0d4b288feb464b13c90eeb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Chalifour?= Date: Wed, 24 Jun 2020 12:21:59 +0200 Subject: [PATCH] fix(docsearch): hoist `transformItems` default value This fixes a bug where the `transformItems` function reference changes and the `autocomplete` instance is recreated every time. --- src/DocSearchModal.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/DocSearchModal.tsx b/src/DocSearchModal.tsx index 7352b23d..300f7569 100644 --- a/src/DocSearchModal.tsx +++ b/src/DocSearchModal.tsx @@ -27,6 +27,10 @@ interface DocSearchModalProps extends DocSearchProps { onClose?(): void; } +function defaultTransformItems(x: DocSearchHit[]) { + return x; +} + export function DocSearchModal({ appId = 'BH4D9OD16A', apiKey, @@ -34,7 +38,7 @@ export function DocSearchModal({ placeholder = 'Search docs', searchParameters, onClose = noop, - transformItems = (x) => x, + transformItems = defaultTransformItems, hitComponent = Hit, resultsFooterComponent = () => null, navigator,