nikon/Codesys-MCP-SP21-plus
0
0
Fork 0
Code Activity Actions

fix: export_xml is reporter-first on SP21 -- all-keyword call + fail-loud existence check

Browse source 
Live verification: positional (objects, None, path, ...) bound 'objects'
into the reporter slot on SP21's overload, silently switching export_xml
into export-to-string mode -- tool reported success with no file written.
All args now passed by keyword; export_plcopen_xml and export_native
raise if the destination file does not exist after the call.
This commit is contained in:
Karstein Phobic Nyvold Kvistad 2026-06-12 15:14:21 +02:00
parent 52f8746268
commit d777832aff
2 changed files with 21 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/scripts/export_native.py
View file

@ -23,11 +23,10 @@ try:
primary_project.export_native(objects, DESTINATION, RECURSIVE)
size_note = "unknown"
try:
size_note = "%s bytes" % os.path.getsize(DESTINATION)
except Exception:
pass
if not os.path.isfile(DESTINATION):
raise RuntimeError(
"export_native returned without error but no file exists at '%s'." % DESTINATION)
size_note = "%s bytes" % os.path.getsize(DESTINATION)
print("Destination: %s" % DESTINATION)
print("Objects: %d (recursive=%s)" % (len(objects), RECURSIVE))

24
src/scripts/export_plcopen_xml.py
View file

@ -21,14 +21,24 @@ try:
objects = list(primary_project.get_children(False))
print("DEBUG: Exporting all %d top-level objects" % len(objects))
# reporter=None -> no reporting; non-exportable objects are skipped by the engine.
primary_project.export_xml(objects, None, EXPORT_PATH, RECURSIVE, True)
size_note = "unknown"
# Keyword args: positional order drifts between SPs (a misplaced 'path'
# silently switches export_xml into export-to-string mode). reporter=None
# -> no reporting; non-exportable objects are skipped by the engine.
# ALL arguments by keyword: SP21's runtime overload is reporter-first
# (stub documents objects-first), so any positional arg can land in the
# wrong slot depending on SP.
try:
size_note = "%s bytes" % os.path.getsize(EXPORT_PATH)
except Exception:
pass
primary_project.export_xml(objects=objects, reporter=None, path=EXPORT_PATH,
recursive=RECURSIVE, export_folder_structure=True)
except TypeError as sig_err:
print("DEBUG: full-keyword call failed (%s); retrying stub positional order." % sig_err)
primary_project.export_xml(objects, None, EXPORT_PATH, RECURSIVE, True)
if not os.path.isfile(EXPORT_PATH):
raise RuntimeError(
"export_xml returned without error but no file exists at '%s'. "
"The engine likely exported to a string (signature drift)." % EXPORT_PATH)
size_note = "%s bytes" % os.path.getsize(EXPORT_PATH)
print("Export Path: %s" % EXPORT_PATH)
print("Objects: %d (recursive=%s)" % (len(objects), RECURSIVE))