nikon/Codesys-MCP-SP21-plus
0
0
Fork 0
Code Activity Actions

fix: source_download -- clean stale Archive.prj, app-level first unless compact

Browse source 
Live verification against the PFC200: device-level download_source on
SP21 writes its temp file into the CODESYS install dir (Program Files)
and dies with access-denied; the failed attempt leaves a locked
Archive.prj in the project dir that breaks the app-level fallback with
'file is being used by another process'. Now: remove stale Archive.prj
up front, use app-level source_download unless compact was explicitly
requested.
This commit is contained in:
Karstein Phobic Nyvold Kvistad 2026-06-12 16:02:42 +02:00
parent fb76d89a8e
commit 22245b91af
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/scripts/source_download.py
View file

@ -10,19 +10,34 @@ try:
app_name = getattr(target_app, 'get_name', lambda: "Unknown")()
ensure_logged_in(online_app)
# Clear a stale Archive.prj in the project dir -- a previously failed
# attempt leaves one behind and the engine then fails with 'file is
# being used by another process'.
stale = os.path.join(os.path.dirname(PROJECT_FILE_PATH), 'Archive.prj')
if os.path.exists(stale):
try:
os.remove(stale)
print("DEBUG: removed stale %s" % stale)
except Exception as e:
print("DEBUG: could not remove stale Archive.prj: %s" % e)
online_device = online_app.get_online_device()
done = False
if hasattr(online_device, 'download_source'):
if COMPACT and hasattr(online_device, 'download_source'):
# Device-level call carries the compact option, but on SP21 it tries
# to write its temp file into the CODESYS install dir (Program
# Files) and dies with access-denied. Try it only when compact was
# explicitly requested.
try:
online_device.download_source(COMPACT)
print("DEBUG: online_device.download_source(bCompact=%s) OK" % COMPACT)
done = True
except Exception as e:
print("DEBUG: online_device.download_source failed: %s" % e)
print("DEBUG: online_device.download_source failed: %s -- falling back to app-level (full, not compact)." % e)
if not done:
# Fallback: application-level source_download (no compact option).
# Application-level source_download (no compact option).
online_app.source_download()
print("DEBUG: online_app.source_download() OK (fallback)")
print("DEBUG: online_app.source_download() OK%s" % (" (compact unavailable)" if COMPACT else ""))
print("Compact: %s" % COMPACT)
print("Application: %s" % app_name)