CANopen: static analysis: increment/decrement operation combined with other operation with side-effects [MISRA 2012 Rule 13.3, advisory]

2024-06-27 13:06:39 +02:00 · 2024-06-27 13:06:39 +02:00 · ff3299918e
commit ff3299918e
parent f6a4718428
1 changed files with 2 additions and 1 deletions
--- a/CANopen.c
+++ b/CANopen.c
@ -1129,13 +1129,14 @@ CO_ReturnError_t CO_CANopenInit(CO_t *co,
        for (uint16_t i = 0; i < CO_GET_CNT(SDO_CLI); i++) {
            err = CO_SDOclient_init(&co->SDOclient[i],
                                    od,
-                                    SDOcliPar++,
+                                    SDOcliPar,
                                    nodeId,
                                    co->CANmodule,
                                    CO_GET_CO(RX_IDX_SDO_CLI) + i,
                                    co->CANmodule,
                                    CO_GET_CO(TX_IDX_SDO_CLI) + i,
                                    errInfo);
+            SDOcliPar++;
            if (err) { return err; }
        }
    }