nikon/CANopenNode
1
0
Fork 0
Code Activity Actions

CO_fifo: static analysis: side effects on right hand of logical operator, '||' [MISRA 2012 Rule 13.5, required]

Browse source 
(cherry picked from commit ea89548ebae934dc3acbcfd6fea15107389f8fd7)
This commit is contained in:
temi54c1l8 2024-06-26 12:18:04 +02:00
parent c46bb96292
commit 376d86a5a4
1 changed files with 8 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
301/CO_fifo.c
View file

@ -1181,7 +1181,7 @@ size_t CO_fifo_cpyTok2Hex(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
if (step == 6U) {
/* command is inside comment, waiting for command delimiter */
bool_t insideComment = true;
if ((c == DELIM_COMMAND) || CO_fifo_trimSpaces(src, &insideComment)) {
if (CO_fifo_trimSpaces(src, &insideComment) || (c == DELIM_COMMAND)) {
st |= CO_fifo_st_closed;
finished = true;
}
@ -1227,7 +1227,7 @@ size_t CO_fifo_cpyTok2Hex(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
step = 0;
}
bool_t insideComment = false;
if ((c == DELIM_COMMAND) || CO_fifo_trimSpaces(src, &insideComment)) {
if (CO_fifo_trimSpaces(src, &insideComment) ||(c == DELIM_COMMAND)) {
/* newline found, finish */
st |= CO_fifo_st_closed;
finished = true;
@ -1312,9 +1312,7 @@ size_t CO_fifo_cpyTok2Vs(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
else if ((isgraph((int)c) == 0) && (step == 2U)) {
/* end of single word string */
bool_t insideComment = false;
if ((c == DELIM_COMMAND)
|| CO_fifo_trimSpaces(src, &insideComment)
) {
if (CO_fifo_trimSpaces(src, &insideComment) || (c == DELIM_COMMAND)) {
st |= CO_fifo_st_closed;
finished = true;
}
@ -1351,9 +1349,7 @@ size_t CO_fifo_cpyTok2Vs(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
if (isgraph((int)c) == 0) {
/* end of quoted string */
bool_t insideComment = false;
if ((c == DELIM_COMMAND)
|| CO_fifo_trimSpaces(src, &insideComment)
) {
if (CO_fifo_trimSpaces(src, &insideComment) || (c == DELIM_COMMAND)) {
st |= CO_fifo_st_closed;
finished = true;
}
@ -1371,7 +1367,7 @@ size_t CO_fifo_cpyTok2Vs(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
case 5: { /* String token is finished, waiting for command delimiter */
bool_t insideComment = false;
if ((c == DELIM_COMMAND) || CO_fifo_trimSpaces(src, &insideComment)) {
if (CO_fifo_trimSpaces(src, &insideComment) || (c == DELIM_COMMAND)) {
st |= CO_fifo_st_closed;
finished = true;
}
@ -1390,7 +1386,7 @@ size_t CO_fifo_cpyTok2Vs(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
}
case 6: { /* String token is finished, waiting for command delimiter */
bool_t insideComment = true;
if ((c == DELIM_COMMAND) || CO_fifo_trimSpaces(src, &insideComment)) {
if (CO_fifo_trimSpaces(src, &insideComment) || (c == DELIM_COMMAND)) {
st |= CO_fifo_st_closed;
finished = true;
}
@ -1459,7 +1455,7 @@ size_t CO_fifo_cpyTok2B64(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
if (step >= 5U) {
/* String token is finished, waiting for command delimiter */
bool_t insideComment = step > 5U;
if ((c == DELIM_COMMAND) || CO_fifo_trimSpaces(src, &insideComment)) {
if (CO_fifo_trimSpaces(src, &insideComment) || (c == DELIM_COMMAND)) {
st |= CO_fifo_st_closed;
finished = true;
}
@ -1500,7 +1496,7 @@ size_t CO_fifo_cpyTok2B64(CO_fifo_t *dest, CO_fifo_t *src, uint8_t *status) {
}
bool_t insideComment = false;
if ((c == DELIM_COMMAND) || CO_fifo_trimSpaces(src, &insideComment)) {
if (CO_fifo_trimSpaces(src, &insideComment) || (c == DELIM_COMMAND)) {
st |= CO_fifo_st_closed;
finished = true;
}