nikon/CANopenNode
1
0
Fork 0
Code Activity Actions

O_SDOserver: static analysis: side effects on right hand of logical operator, '&&' [MISRA 2012 Rule 13.5, required]

Browse source 
because SDO->state is volatile
This commit is contained in:
temi54c1l8 2024-06-14 09:02:17 +02:00
parent ab26145597
commit 06834c1d14
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
301/CO_SDOserver.c
View file

@ -704,7 +704,7 @@ CO_SDO_return_t CO_SDOserver_process(CO_SDOserver_t *SDO,
bool_t isNew = CO_FLAG_READ(SDO->CANrxNew);
if (SDO->valid && (SDO->state == CO_SDO_ST_IDLE) && !isNew) {
if ((SDO->state == CO_SDO_ST_IDLE) && SDO->valid && !isNew) {
/* Idle and nothing new */
ret = CO_SDO_RT_ok_communicationEnd;
}
@ -809,7 +809,9 @@ CO_SDO_return_t CO_SDOserver_process(CO_SDOserver_t *SDO,
#endif /* (CO_CONFIG_SDO_SRV) & CO_CONFIG_SDO_SRV_SEGMENTED */
} /* (SDO->state == CO_SDO_ST_IDLE) */
if ((SDO->state != CO_SDO_ST_IDLE) && (SDO->state != CO_SDO_ST_ABORT)) {
bool isOKstate = (SDO->state != CO_SDO_ST_IDLE);
isOKstate = (SDO->state != CO_SDO_ST_ABORT) && isOKstate;
if (isOKstate) {
switch (SDO->state) {
case CO_SDO_ST_DOWNLOAD_INITIATE_REQ: {
if ((SDO->CANrxData[0] & 0x02U) != 0U) {